Skip to content

[TOOL-3377] Portal: Remove v4 SDK links, setup missing redirects #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

[TOOL-3377] Portal: Remove v4 SDK links, setup missing redirects #6222

merged 1 commit into from
Feb 11, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 10, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating wallet references and improving documentation related to local and smart wallets, including changes to routing paths and descriptions in various markdown files.

Detailed summary

  • Updated routing paths in apps/portal/redirects.mjs.
  • Revised descriptions of local and smart wallets in multiple .mdx files for clarity.
  • Changed links from old wallet references to new TypeScript v5 paths.
  • Removed guest mode card from apps/dashboard/src/app/(landing)/in-app-wallets/page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 10, 2025

TOOL-3377 Fix missing v4 redirects in portal

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9dcf595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:07pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) Feb 10, 2025 7:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 10, 2025 7:07pm
wallet-ui ⬜️ Skipped (Inspect) Feb 10, 2025 7:07pm

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels Feb 10, 2025
@MananTank MananTank marked this pull request as ready for review February 10, 2025 17:36
@MananTank MananTank requested review from a team as code owners February 10, 2025 17:36
@MananTank Graphite App
Copy link
Member Author

MananTank commented Feb 10, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (92266b7) to head (d4cd95d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6222   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        1161     1161           
  Lines       64289    64289           
  Branches     5196     5196           
=======================================
  Hits        36468    36468           
  Misses      27095    27095           
  Partials      726      726
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 92266b7
packages 54.89% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.28 KB (0%) 926 ms (0%) 940 ms (+91.21% 🔺) 1.9 s
thirdweb (cjs) 122.06 KB (0%) 2.5 s (0%) 1.5 s (+8.83% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 169 ms (+117.24% 🔺) 281 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 15 ms (-17.78% 🔽) 25 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 340 ms (+62.56% 🔺) 726 ms

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 17:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 17:40 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 17:40 Inactive
graphite-app[bot]
graphite-app bot reviewed Feb 10, 2025
View reviewed changes
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 17:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 17:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 17:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 17:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 17:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 17:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 17:43 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2025 •
edited
Loading

Merge activity

  • Feb 10, 1:47 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 10, 2:00 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

@MananTank
[TOOL-3377] Portal: Remove v4 SDK links, setup missing redirects (#6222)
9dcf595 
<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating references and improving the documentation for wallets, particularly in the context of smart accounts and local wallets. It also modifies some links to reflect new versions and removes outdated content.

### Detailed summary
- Updated wallet references from `/references/wallets/v2/` to `/typescript/v5/supported-wallets/`.
- Clarified descriptions of smart accounts and local wallets.
- Removed mentions of guest mode in `page.tsx`.
- Adjusted links for `SmartWallet` and `AWS KMS Wallet`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 10, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 10, 2025 18:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 10, 2025 18:58 Inactive
@joaquim-verges joaquim-verges merged commit 51f9553 into main Feb 11, 2025
29 of 30 checks passed
@joaquim-verges joaquim-verges deleted the TOOL-3377 branch February 11, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@joaquim-verges joaquim-verges joaquim-verges approved these changes

@jnsdls jnsdls jnsdls approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MananTank @joaquim-verges @jnsdls